[main] [bug] Catch RequestException instead of Throwable in DatabaseDelete#138
Merged
joetannenbaum merged 1 commit intolaravel:mainfrom Apr 10, 2026
Conversation
Throwable catches everything including TypeError, OutOfMemoryError, etc. masking real bugs as API errors. All other delete commands catch RequestException. This makes DatabaseDelete consistent. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46
Summary
DatabaseDeletecatchesThrowableinstead ofRequestException. This catches everything includingTypeError,OutOfMemoryError, and other non-API errors, masking real bugs as "Failed to delete database" messages. All other delete commands catchRequestException.Proof
Before / After
Consistency
Every other delete command already catches
RequestException:ApplicationDeleteBackgroundProcessDeleteDatabaseClusterDeleteDomainDeleteEnvironmentDeleteInstanceDeleteDatabaseDeletewas the only outlier.