Accept bucket arg on bucket-key:delete and bucket-key:update#148
Merged
joetannenbaum merged 1 commit intomainfrom Apr 21, 2026
Merged
Accept bucket arg on bucket-key:delete and bucket-key:update#148joetannenbaum merged 1 commit intomainfrom
joetannenbaum merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both commands were missing the
{bucket?}positional argument that the otherbucket-key:*commands already accept, which meant the bucket could only be picked interactively. That blocked any non-interactive use and was inconsistent with siblings likebucket-key:create|get|list.Adds the arg to both signatures and swaps the
->resolve()call for->from($this->argument('bucket'))so the identifier actually flows through to the resolver.Refs #115