fix: improve resolver error messages with specific failure context#37
Open
JoshSalway wants to merge 1 commit intolaravel:mainfrom
Open
fix: improve resolver error messages with specific failure context#37JoshSalway wants to merge 1 commit intolaravel:mainfrom
JoshSalway wants to merge 1 commit intolaravel:mainfrom
Conversation
Replace generic "Unable to resolve X" messages across all resolvers with distinct errors that tell the user exactly what went wrong: ID not found, name not found, repo not matched, or no identifier provided. Also improve the base Resolver to distinguish API 404s from permission errors (403) and other HTTP failures, re-throwing non-404 errors instead of silently swallowing them. Closes laravel#30 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolver::resolveFromIdentifier()to catchSaloon\Exceptions\Request\RequestExceptionspecifically — 404s fall through to name-based lookup, while 403 (permission) and other HTTP errors are re-thrown with context instead of being silently swallowedlooksLikeId()helper to the base Resolver, reused by all subclasses to tailor error messages based on whether the user provided an ID or a nameBefore
After
Closes #30
Test plan
./vendor/bin/pest— 31 passed)app/Resolvers/cloud app:info bad-nameand verify "No application named 'bad-name' found" messagecloud app:info app-nonexistent123and verify "Application 'app-nonexistent123' not found" messagecloud env:infofrom a non-linked repo and verify repo-specific or generic fallback message🤖 Generated with Claude Code