Skip to content

Conversation

@adamgoose
Copy link
Contributor

No description provided.

@adamgoose
Copy link
Contributor Author

Well shoot... In order for this to be an option, this needs to be tweaked to allow merging. How do you (@taylorotwell) propose we make this possible?

@brunogaspar
Copy link
Member

What/why it needs to be tweaked?
I tested it earlier today and it worked fine on my end. Doesn't it work on your end?

Also i don't believe base_path('database/migrations') is the correct approach here, what if the application has a different folder structure? Which is completely doable..
In that case the migrations will be placed on the wrong directory or maybe it will throw errors due to permissions.

Probably something like $this->app->databasePath().'/migrations' should suffice i guess.

@adamgoose
Copy link
Contributor Author

You're probably right, but if you read my linked line, you'll see that if the destination folder exists, he skips publishing said files.

@brunogaspar
Copy link
Member

Oh i see, sorry i misread it.

@GrahamCampbell
Copy link
Contributor

Please resend to 5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants