[5.0] Fix Vendor Publish Command #7156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the `vendor:publish` command to publish directories properly, otherwise if the directory we're publishing already exists, the files never get's published. Example, publishing migrations of a package, these migrations would never be published because the `database/migrations` already exists.
Member
|
This wasn't entirely correct, but I fixed, and it wasn't too bad thanks to @frankdejonge's |
Member
Author
|
Thanks @taylorotwell ! |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we're publishing a directory from a package and this directory already exists on the application, even if the files don't, the package directory contents never gets published.
Example, publishing migrations of a package, these migrations would never be published because the
database/migrationsalready exists therefore it gets ignored by this lineThis was the most simpler way i could find to make it work.
Related: laravel/docs#1047