Skip to content

Conversation

@Amirhf1
Copy link

@Amirhf1 Amirhf1 commented Dec 8, 2025

Description
Improved clarity of the temporarySignedRoute example by adding an inline
comment explaining that now() is a Laravel helper function.

Motivation
New Laravel developers might be confused seeing now() without any import
statement. This small addition helps them understand that it's a built-in
Laravel helper, not requiring explicit Carbon import.

Changes

  • Added inline comment to clarify now() helper function usage
  • Helps beginners understand Laravel's helper functions better

Added inline comment to explain that now() is a Laravel helper function
to help new developers understand they don't need to explicitly import Carbon.
This improves documentation clarity for beginners.
@shaedrich
Copy link
Contributor

shaedrich commented Dec 8, 2025

Despite the description saying, the PR explains this, I cannot see the actual changes explicitly reflecting that. It just results in an unused import.

Furthermore, helper functions are a core concept of the framework, not something specifically tied to signed URLs. Feeling the need to add this here, would require us to add this everywhere where helpers are used in the documentation—which sounds like quite an overhead as compared to just consulting the /helpers docs page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants