fix: update retryUntil() return type from DateTime to DateTimeInterface#11150
Merged
taylorotwell merged 1 commit intolaravel:13.xfrom Apr 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in events.md line
688, it says:However, this is not proper for the latest versions of Laravel. By default,

now()returns an instance ofCarbon\CarbonImmutable(or its parentCarbonInterface) andCarbonInterfaceextends the\DateTimeInterface, notDateTime.As a result, using
DateTimeas the return type may cause a fatal error:See issue #745 in laravel/boost. because the
retryUntilmethod don't always return aDateTimeinstance, but we can be sure that the returned object always implementsDateTimeInterface.So, the correct (and better) return type would be:
I've added a fix regarding this in laravel-boost in PR #748, which was merged.
This PR updates the official doc accordingly, which would help prevent confusion and runtime errors. and this tiny change can encourage alignment with Laravel’s internal expectations, following best practices (programming to an interface), as well as keeping the method compatible with both
DateTimeandCarbonImmutablereturn types.Thanks.