[13.x] put _type before _id for polymorphic table columns#11188
Merged
Conversation
This commit orders all of our polymorphic table columns with `*_type` first and `*_id` second.
This matches how the columns are actually generated by the migration helper methods:
```php
$table->nullableulidMorphs('nullableulidMorphs');
$table->ulidMorphs('ulidMorphs');
$table->uuidmorphs('uuidmorphs');
$table->nullableUuidMorphs('nullableUuidMorphs');
$table->morphs('morphs');
$table->nullableMorphs('nullableMorphs');
```
results in:
- nullableulidMorphs_type
- nullableulidMorphs_id
- ulidMorphs_type
- ulidMorphs_id
- uuidmorphs_type
- uuidmorphs_id
- nullableUuidMorphs_type
- nullableUuidMorphs_id
- morphs_type
- morphs_id
- nullableMorphs_type
- nullableMorphs_id
This will help encourage consistency between morph columns generated by the helpers, and any the user may manually define.
I think it also makes sense from a readability standpoint; Comment 5, Tag 17, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit orders all of our polymorphic table columns with
*_typefirst and*_idsecond.This matches how the columns are actually generated by the migration helper methods:
results in:
This will help encourage consistency between morph columns generated by the helpers, and any the user may manually define.
I think it also makes sense from a readability standpoint; Comment 5, Tag 17, etc.