replace first class callables with comments #7951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
commented
May 24, 2022
Comment on lines
-751
to
+753
| .listen(...) | ||
| .listen(...) | ||
| .listen(...); | ||
| .listen(/* ... */) | ||
| .listen(/* ... */) | ||
| .listen(/* ... */); |
There was a problem hiding this comment.
These aren't first class callables, being JS, but I adjusted these to match the rest of the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PHP first class callables now using this syntax, we should probably change the way we express "and you put your things in here" for function calls.
Suggesting we utilise
/* ... */, which is a thing I've seen pretty commonly I feel.