[5.0] automatically fit content on failures #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will automatically resize the browser to fit the content before taking screenshots on failures.
This was referenced Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a feature a couple months ago called
fitContentwhich resizes the browser to the dimensions of the content.#655
Finally got around to documenting it today.
laravel/docs#5658
Next step is to have this automatically happen prior to taking screenshots.
I think we can safely enable this on a minor or patch release, but if people have strong objections to that, I can default it to
falsefor now, and enable it onmasterfor the 6.0 release.