feat: add broadcaster type inference to constructor #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By explicitly intersecting the
EchoOptions<T>type with{ broadcaster: T }, we make the broadcaster field the source of truth for generic parameter T.Previously, when only using
EchoOptions<T>TypeScript couldn’t reliably infer T from the value of options.broadcaster.This meant you either had to manually specify the type parameter (
new Echo<"pusher">({...})) or you’d lose precise typing for the connector and channel methods.