Fix typo, password exposure, version check error handling, and UX improvements#110
Open
JoshSalway wants to merge 1 commit intolaravel:masterfrom
Open
Fix typo, password exposure, version check error handling, and UX improvements#110JoshSalway wants to merge 1 commit intolaravel:masterfrom
JoshSalway wants to merge 1 commit intolaravel:masterfrom
Conversation
- Fix "deamon" typo in DaemonRestartCommand error message (fixes #6) - Use MYSQL_PWD env var instead of -p flag to avoid password exposure (fixes #7) - Add try-catch and timeout to version check file_get_contents (fixes #8) - Use daemon argument when provided instead of always prompting (fixes #9) - Add confirmation prompt before logout flushes config (fixes #10) - Move file existence check before confirmation in EnvPushCommand (fixes #11) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112, #113, #114, #115, #116
Summary
Security
DatabaseShellCommandpasses password via-pCLI argument, visible inps aux. Changed toMYSQL_PWDenvironment variable.Bug fixes
InteractsWithVersionscalls Packagist with no timeout or error handling. Added 5s timeout, try-catch fallback to current version.DaemonRestartCommanderror message.DaemonLogsCommandandDaemonRestartCommanddefine a{daemon}argument but always prompt interactively. Now checks argument first.UX
LogoutCommandflushes all config without confirmation. Added confirmation prompt.Test plan
database:shellconnects without exposing password inps auxdaemon:restart 123anddaemon:logs 123use the argument without promptinglogoutasks for confirmation before clearing config🤖 Generated with Claude Code