Hide unimplemented command, centralize DB types, improve null safety#111
Open
JoshSalway wants to merge 1 commit intolaravel:masterfrom
Open
Hide unimplemented command, centralize DB types, improve null safety#111JoshSalway wants to merge 1 commit intolaravel:masterfrom
JoshSalway wants to merge 1 commit intolaravel:masterfrom
Conversation
…, add null safety - Hide DaemonStatusCommand from help since it is not implemented (fixes #12) - Add shared database type constants and helper methods to InteractsWithDatabase trait, and use them across DatabaseLogsCommand, DatabaseStatusCommand, DatabaseShellCommand, and DatabaseRestartCommand (fixes #13) - Add proper null validation in askForSite and askForServer to abort with clear error messages instead of passing invalid name strings as IDs (fixes #14) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122, #123, #124
Summary
DaemonStatusCommandappears inforge listbut immediately aborts with "not yet supported" — now hiddenInteractsWithDatabasetrait withisMysqlDatabase(),isPostgresDatabase(), andsupportedDatabaseTypes()helpersaskForSite()andaskForServer()fall back to passing raw name string as API ID when no match found — now shows clear error message insteadTest plan
daemon:statusno longer appears inforge listoutput🤖 Generated with Claude Code