[master] [fix ci] Upgrade to Laravel Zero 12#146
Open
JoshSalway wants to merge 2 commits intolaravel:masterfrom
Open
[master] [fix ci] Upgrade to Laravel Zero 12#146JoshSalway wants to merge 2 commits intolaravel:masterfrom
JoshSalway wants to merge 2 commits intolaravel:masterfrom
Conversation
Fix warnings in php 8.4 by upgrading to laravel-zero 12 Remove spatie/once dependency
- Replace removed Once\Cache::flush() with Illuminate\Support\Once::flush() in ServerSwitchCommand and tests/Pest.php (cache must be flushed after server context switch and between tests) - Revert version bump from 2.0.0 to 1.8.3 (maintainer decision) - Restore larastan extension.neon include (still needed in larastan 3.x) - Remove unnecessary phpstan additions (scanDirectories, rootDir, tmpDir) - Fix trailing comma in composer.json require-dev
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the CLI from Laravel Zero 10 to Laravel Zero 12. Based on the work by @buzkall in #101, with fixes applied on top.
Commits
Once::flush(), revert version bump, fix phpstan config, fix trailing commaChanges
^8.1to^8.2laravel-zero/frameworkfrom^10.0.2to^12.0larastan/larastanfrom^2.6.0to^3.0pestphp/pestfrom^2.6.1to^3.0spatie/once, replace withIlluminate\Support\Once(Laravel 11+ built-in): intreturn type toCommand::execute()(PHP 8.4 deprecation fix)What this may fix
composer installcurrently fails on master due to dependency conflicts, which means the test suite can't run. This upgrade resolves the dependency issues. Note: thetestsworkflow has been automatically disabled by GitHub due to inactivity. After merging, a maintainer will need to re-enable it via Actions > tests > Enable workflow.Testing
Tested locally on PHP 8.4.18 (WSL/Linux) and PHP 8.4.19 (Windows).
Post-merge checklist
testsworkflow in Actions > tests > Enable workflow (disabled by GitHub due to inactivity).github/workflows/tests.yml(see [master] [ci] Update test matrix: drop PHP 8.1, add PHP 8.4 #147)