[master] [bug] Fix crash in ssh:configure when key generation fails#149
Open
JoshSalway wants to merge 1 commit intolaravel:masterfrom
Open
[master] [bug] Fix crash in ssh:configure when key generation fails#149JoshSalway wants to merge 1 commit intolaravel:masterfrom
JoshSalway wants to merge 1 commit intolaravel:masterfrom
Conversation
KeyRepository::create() calls keysFactory.php via exec() and json_decodes the result without checking for failure. If the subprocess fails (wrong PHP binary, missing deps, PHAR path issues), json_decode returns null and the subsequent array access crashes with "Trying to access array offset on null". This adds an abort_if guard with a helpful error message pointing to the script that failed. Fixes laravel#96
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyRepository::create()callskeysFactory.phpviaexec()andjson_decodes the result without checking for failure. If the subprocess fails (wrong PHP binary, missing dependencies, PHAR path issues),json_decodereturns null and the subsequent array access crashes with:This adds an
abort_ifguard with a helpful error message pointing to the script that failed to execute.Fixes #96
Before
After
Testing