remove use of == and != from the framework

[xcombelle]

#19995 Looks like the use of == or != leads to bugs which would be easily avoided by using only strict comparison

A simple search show that they are lot of them

$ egrep "([^']!=[^=])" . -R |wc -l
46
$ egrep "([^=!']==[^='])" . -R|wc -l
166

A good thing to do would be, once these occurrence removed would be to add a pre or post commit hook to avoid future insertions.

EDIT bad bug reference

[browner12]

that's a pretty broad statement, and not always applicable IMO.

they should be dealt with on a case-by-case basis.

[xcombelle]

I quickly looks on the result and found zero case it should not be applicable. If conversion is needed, it should be explicitly made. So implicit conversion should not be used.

[koenhoeijmakers]

Although i'm for strict comparison, but i'm not that much for regexing the whole project and expecting nothing to break.

[xcombelle]

I agree, that some change will break things, that's why I did not proposed an automatic replacement. It should be considered as a long term aim. At the very least, a warning should be raised if new occurrences are introduced by some commit.

[Dylan-DPC-zz]

This is not a bug. Open an issue in the laravel/internals repo

[xcombelle]

migrated to the right bug tracker.