Can't use fully qualified class names in namespaced routes

[Lloople]

• Laravel Version: 5.7.1
• PHP Version: 7.2
• Database Driver & Version: MySQL 5.6

Description:

The Router class is appending the group namespace to a route which has been declared as a single action controller using fully qualified class name.

The problem is that a fully qualified class name doesn't starts with \, so the code in prependGroupNamespace will concatenate the namespace to it.

App\Http\Controllers\InvokableController::class will evaluate to App\Http\Controllers\App\Http\Controllers\Invokable

Steps To Reproduce:

Create an invokable controller: php artisan make:controller InvokableController --invoke

Declare a route in your web.php file:

Route::get('invokable', \App\Http\Controllers\InvokableController::class);

[Miguel-Serejo]

There are two workarounds:

In your RouteServiceProvider, you can change the default namespace:

    /**
     * This namespace is applied to your controller routes.
     *
     * In addition, it is set as the URL generator's root namespace.
     *
     * @var string
     */
    protected $namespace = '';

And then group all the namespaced routes in your web.php file:

<?php

/*
|--------------------------------------------------------------------------
| Web Routes
|--------------------------------------------------------------------------
|
| Here is where you can register web routes for your application. These
| routes are loaded by the RouteServiceProvider within a group which
| contains the "web" middleware group. Now create something great!
|
*/

Route::namespace('App\Http\Controllers')->group(function() {
  //namespaced routes go here
});

//non-namespaced routes go here
Route::get('invokable', \App\Http\Controllers\InvokableController::class);

Alternatively, you can add a new route file, say, "routes/invokable.php" and register it in your RouteServiceProvider:

(...)
public function map()
{
    $this->mapApiRoutes();
    $this->mapWebRoutes();
    $this->mapInvokableRoutes();
}

(...)
protected function mapInvokableRoutes()
{
    Route::middleware('web')->group(base_path('routes/invokable.php'));
}

[phannaly]

Should someone PR on this issue.

[Lloople]

I did, but got closed. I think because of lack of information or understanding the problem.

[phannaly]

@Lloople I can't find your PR. Can you give me a link? I'm interested in this issues and want to look at your PR.

[Lloople]

#25504

[driesvints]

As this isn't really bug but just an unsupported thing I'm closing this. Feel free to open up an issue in https://github.com/laravel/ideas if you want this to be added and to gather support.

[Spudley]

There are two workarounds:

In your RouteServiceProvider, you can change the default namespace:

    /**
     * This namespace is applied to your controller routes.
     *
     * In addition, it is set as the URL generator's root namespace.
     *
     * @var string
     */
    protected $namespace = '';

For the benefit of anyone arriving at this thread looking for help with namespacing their routes, I just want to flag up the comment above and point out the fact that while this workaround does work, it breaks if you're using any of Laravel's routing helpers. For example, if you have a call to Auth::routes() in your routing file as a shortcut to give you the standard Laravel login routes, those routes rely on the default namespace being unchanged, and will break if you've set it to a blank string per the advice above.

You can fix this by using Route::namespace() as described, but I felt it was important to emphasise this as the previous comment didn't really explain why you'd need to use that method.

[raraworks]

There are two workarounds:
In your RouteServiceProvider, you can change the default namespace:

    /**
     * This namespace is applied to your controller routes.
     *
     * In addition, it is set as the URL generator's root namespace.
     *
     * @var string
     */
    protected $namespace = '';

For the benefit of anyone arriving at this thread looking for help with namespacing their routes, I just want to flag up the comment above and point out the fact that while this workaround does work, it breaks if you're using any of Laravel's routing helpers. For example, if you have a call to Auth::routes() in your routing file as a shortcut to give you the standard Laravel login routes, those routes rely on the default namespace being unchanged, and will break if you've set it to a blank string per the advice above.

You can fix this by using Route::namespace() as described, but I felt it was important to emphasise this as the previous comment didn't really explain why you'd need to use that method.

You can always leave the namespace property alone and use map function in your applications RouteServiceProdvider class, where you can call Route::group call without using namespace functionality.
Check: https://github.com/laravel/laravel/blob/b0ce2adc423ff175a20838ee5f2c858cbc63b11f/app/Providers/RouteServiceProvider.php#L62