Validation: failed dependent rule message uses lowercase

[RobertWeideKyos]

Laravel Version

12.37.0

PHP Version

8.4.14

Database Driver & Version

No response

Description

When validating using rules that depend on other fields (like required_if or prohibited_if), the failed message contains a lower case string of the passed in value. This is confusing if the value that was checked against is not lower case. It is also confusing that the passed in value is used, rather then the value that it was checked against.

Steps To Reproduce

use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\Rule;

$correct = Validator::make(['field1' => 'aa'], ['field1' => 'required', 'field2' => 'required_if:field1,AA', 'field3' => 'required_if:field1,aa']);

// Will output "The field3 field is required when field1 is aa."
$correct->validate();

$wrong = Validator::make(['field1' => 'AA'], ['field1' => 'required', 'field2' => 'required_if:field1,AA', 'field3' => 'required_if:field1,aa']);

// Will output "The field2 field is required when field1 is aa." (Note the case).
$wrong->validate();

// Special edge case
$wrong = Validator::make(['field1' => 'False'], ['field1' => ['required', 'boolean'], 'field2' => 'required_if:field1,true']);

// Will output "The field1 field must be true or false. (and 1 more error)."
$wrong->validate(); 

// Returns "The field2 field is required when field1 is false." (But the rule checks for true).
$wrong->errors()->get('field2');

[achrafAa]

Hey @RobertWeideKyos

Thanks for reporting this issue and sharing a clear example, that was super helpful!

I’ve opened a PR to fix it: #57679
It would be great if you could test it and let me know if it works for you.

Thanks again! 🙌

[achrafAa]

from Taylor
"This doesn't throw any validation errors at all (correctly):

$v = Validator::make([
    'status' => 'active',
], [
    'status' => 'required',
    'reason' => 'required_if:status,inactive',
]);

$v->passes();

dd($v->errors()->all());

"
@RobertWeideKyos can you please check, I m currently unable to retest

[RobertWeideKyos]

@achrafAa The changes to ValidationValidatorTest.php in your PR made me realize that required_if can take a list of values. That explains the choice to go with the passed in value, to avoid a potential long list in the error message. When casting is involved, there is still the possibility that the compared values are actually very different, but this is an edge case.

If we focus on just the case change, your example would be like this:

$v = Validator::make([
    'status' => 'Active',
], [
    'status' => 'required',
    'reason' => 'required_if:status,Active',
]);

$v->passes();

dd($v->errors()->all());

// ❌ Current error: "The reason field is required when status is active."
// (Shows lowercase of what user submitted)

// ✅ Expected error: "The reason field is required when status is Active."
// (Shows what user actually submitted)

[achrafAa]

@RobertWeideKyos got it, Taylor's example works correctly because 'active' (lowercase) doesn't change, The issue example shows the problem: when user submits "Active" or "AA", the error message lowercases it to "active" or
"aa",This happens because replaceWhileKeepingCase applies the case transformation based on the placeholder in the translation message
i will create an other PR and clarify this

[achrafAa]

@RobertWeideKyos I tried submitting another PR earlier, but it wasn’t merged and was closed by Taylor, probably because it wasn’t critical and would have just added more code to the framework, increasing maintenance. Maybe someone else will come up with a better approach.