Arr::first() helper not working with model property cast to AsArrayObject

[n-hor]

Laravel Version

12.39

PHP Version

8.4

Database Driver & Version

No response

Description

After the recent changes in
https://github.com/laravel/framework/blame/a925110b0ad6aa4a7bf7a03ee27ab52931b3e8ab/src/Illuminate/Collections/Arr.php#L274

My code started breaking, as every place where I use Arr::first() on a model property cast to AsArrayObject stopped working. I now get the following error:

array_find_key(): Argument #1 ($array) must be of type array, Illuminate\Database\Eloquent\Casts\ArrayObject given

 ErrorException 

  array_find_key(): Argument #1 ($array) must be of type array, Illuminate\Database\Eloquent\Casts\ArrayObject given

  at vendor/laravel/framework/src/Illuminate/Collections/Arr.php:274
    270▕ 
    271▕             return value($default);
    272▕         }
    273▕ 
  ➜ 274▕         $key = array_find_key($array, $callback);
    275▕ 
    276▕         return $key !== null ? $array[$key] : value($default);
    277▕     }
    278▕

Steps To Reproduce

Create a model with a property cast to AsArrayObject:

class Product extends Model
{
    protected $casts = [
        'prices' => AsArrayObject::class,
    ];
}

$product = Product::first();

Arr::first($product->prices, fn ($price) => $price === 0); // using callback

[NavDevP]

Cause

Laravel Casts\ArrayObject does not implement array or Traversable, that's why it's throwing the error.

Suggested Fix

Before passing the value into array_find_key() convert Laravel ArrayObject into a native array:

if ($array instanceof \Illuminate\Database\Eloquent\Casts\ArrayObject) {
    $array = $array->getArrayCopy();
}

 $key = array_find_key($array, $callback);

[n-hor]

The issue is that the approach is inconsistent depending on whether a callback is passed.
If no callback is provided, an additional is_array check is performed and then a native PHP function is called.
The approach should be the same for both cases.

It should be refactored as follows:

public static function first($array, ?callable $callback = null, $default = null)
{
    if(is_array($array)) {

        if (empty($array)) {
            return value($default);
        }


        if(is_null($callback)) {
            return array_first($array);
        }

        $key = array_find_key($array, $callback);
        
        return $key !== null ? $array[$key] : value($default);
    }
    
    foreach ($array as $item) {
        if(is_null($callback)) {
            return $item;
        }
 
         if($callback($item)) {
            return $item;
         }
    }

    return value($default);
}