[5.0] Edited: Illuminate\Routing\Stack always uses $this->request instead of the passed $request at the end of the initial Middleware stack.

[Aaron3]

Is this intentional? It seems that Middleware should be able to change the request going in and out of it. It can pass along changes to other Middleware but after all the Middleware is run, Laravel ignores the changes on the initial request.

This Middleware runs on every request:

class GetLocale implements Middleware {
    public function handle($request, Closure $next)
    {
        //url: site.com/en/someurl/
        $modifiedRequest = $request->duplicate();
        $language = $request->segment(1);
        if(is_valid_language($language))
        {
            //do stuff with $language
            $modifiedRequest->server->set('REQUEST_URI', strip_language($request->path());
            //url: site.com/someurl/
            return $next($modifiedRequest);
        }
    }
}

After GetLocale runs, the other Middleware functions as I would expect but \Illuminate\Routing\Stack::then() returns the original request because of getInitialSlice and a route not found exception is thrown because site.com/en/someurl/ doesn't actually exist.

Editing Illuminate\Routing\Stack to use a passed $request rather than $this->request everything function as expected and site.com/en/someurl/ resolves transparently to site.com/someurl/ .

The following works exactly as I'd expect.

    protected function getInitialSlice(Closure $app)
    {
        return function($request) use ($app)
        {
            return call_user_func($app, $request);
        };
    }

On Middleware run later and not on every load, it always uses the passed $request at the end:

framework/src/Illuminate/Routing/ControllerDispatcher.php

Line 104 in 62ae860

return (new Stack($this->container))

[usm4n]

Hi, You are doing it the wrong way, It's not a bug read the code below carefully and it will work.

    public function handle($request, Closure $next)
    {
        $dupRequest = $request->duplicate();
        $segment = $dupRequest->segment(1);
        if(is_valid_language($segment))
        {
           $request->server->set('REQUEST_URI',str_replace($segment,'',$dupRequest->path()));
           return $next($request);
        }
    return $next($request);
    }

Passing the $modifiedRequest into the $next changes the ref id of the $request object.
Regards,

[Aaron3]

It doesn't work with middleware that is run automatically on every load because of the issue in getInitialSlice like I showed above.

[usm4n]

Hmmm I actually tested it on the application level middlewares i.e. by adding the middleware in the App\Http\Kernel class. You can change the request uri path in route middlewares but it does not make any difference because route level middlewares are called after a route is matched.

Let us wait for someone else to step in :).

[usm4n]

Ok see if changing the method getSlice like this solves the issue:

    protected function getSlice()
    {
        return function($stack, $middleware)
        {
            return function($request) use ($stack, $middleware)
            {
                $this->request = $request; //resetting the $this->request here.
                return $this->container->make($middleware)->handle($request, $stack);
            };
        };
    }

[Aaron3]

The issue is getInitialSlice like I showed above. It forces $this->request as the argument instead of the passed $request;

[usm4n]

Yes resetting the $this->request = $request in getSlice will solve this issue. Its because the closure from the getInitialSlice will be called at last.

[jonathanpmartins]

@Aaron3 @usm4n
Did you make a pull request? Could you tell me if this issue has already been solved?

[Aaron3]

No, I didn't make a pull request and it hasn't been solved.

[jonathanpmartins]

To me it seems to be working fine! with a image filter like yours, if I select another file it returns me a validation error, normally.

[jonathanpmartins]

Can you get more information of you code flow?

[GrahamCampbell]

Closed due to no response.