[5.5] Fix travis CI error#20329
Merged
taylorotwell merged 4 commits intolaravel:masterfrom Jul 31, 2017
fernandobandeira:patch-1
Merged
[5.5] Fix travis CI error#20329taylorotwell merged 4 commits intolaravel:masterfrom fernandobandeira:patch-1
taylorotwell merged 4 commits intolaravel:masterfrom
fernandobandeira:patch-1
Conversation
|
|
||
| before_install: | ||
| - phpenv config-rm xdebug.ini | ||
| - if [[ $TRAVIS_PHP_VERSION != 7.2 ]] ; then phpenv config-rm xdebug.ini; fi |
Collaborator
There was a problem hiding this comment.
This is brittle with time. We should check if that config exists, rather than a switch on the php version.
Member
|
What is all this xdebug garbage? I still don't understand why it is even there AT ALL? |
Contributor
Author
|
It's there to disable xdebug when testing our builds, since xdebug makes the testing proccess slower we remove the config file before starting the build to disable it, however some PHP versions aren't supported by xdebug (like 7.2 for example) thus there's no file to be removed. |
Member
|
But it's making our tests a lot slower having this line there because the builds end up not running at all every time something with PHP changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As comment on #20258 (comment) this fixes the error on travisCI, I've sent a separate PR to fix the other internal count error for the 5.4 branch #20330.
Those 14(5.4)/22(5.5) count errors should be fixed when mockery/mockery#771 gets merged,