Display name using v-pre in auth scaffolding#21659
Closed
suth wants to merge 1 commit into
Closed
Conversation
Member
|
I don't really understand what you're talking about. Why would we put a v-pre directive on a page that doesn't even use Vue at all? |
Author
|
Out of the box Laravel includes a compiled JS file that mounts Vue to This video follows those three steps exactly: https://streamable.com/k2uc5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The default auth scaffolding displays the user's name HTML escaped, but if the user has used curly braces the default Vue setup will try to interpolate it. This could lead to the user executing javascript or breaking the page rendering entirely. I don't believe this is a security vulnerability since it will only happen to the currently authenticated user, but a good example should be set for users.
Steps to Reproduce
php artisan auth:make{{ breaksPage }}or{{ alert('Hello World') }}Solution
Use the
v-preVue directive on the element displaying the name.