[7.x] Add missing imports#32276
Closed
lucasmichot wants to merge 3 commits intolaravel:7.xfrom
lucasmichot:feature/7.x/add-missing-imports
Closed
[7.x] Add missing imports#32276lucasmichot wants to merge 3 commits intolaravel:7.xfrom lucasmichot:feature/7.x/add-missing-imports
lucasmichot wants to merge 3 commits intolaravel:7.xfrom
lucasmichot:feature/7.x/add-missing-imports
Conversation
Member
|
The ones on the encrypt functions are for security. |
Contributor
Author
|
See e9f23a3 Taylor |
GrahamCampbell
requested changes
Apr 7, 2020
| public function runningInConsole() | ||
| { | ||
| if ($this->isRunningInConsole === null) { | ||
| $this->isRunningInConsole = Env::get('APP_RUNNING_IN_CONSOLE') ?? (\PHP_SAPI === 'cli' || \PHP_SAPI === 'phpdbg'); |
Collaborator
There was a problem hiding this comment.
Please revert these. They are there for performance reasons because runningInConsole is hot code in most apps.
GrahamCampbell
requested changes
Apr 7, 2020
| // instance on retrieval, which makes it quite convenient to work with | ||
| // date fields without having to create a mutator for each property. | ||
| if ($value !== null | ||
| && \in_array($key, $this->getDates(), false)) { |
Collaborator
There was a problem hiding this comment.
This slash also included because this is hot code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing imports.