Skip to content

[7.x] Add AuthenticationException on Gate#32419

Closed
Oipnet wants to merge 4 commits intolaravel:7.xfrom
Oipnet:gate-unauthenticated-user
Closed

[7.x] Add AuthenticationException on Gate#32419
Oipnet wants to merge 4 commits intolaravel:7.xfrom
Oipnet:gate-unauthenticated-user

Conversation

@Oipnet
Copy link
Copy Markdown

@Oipnet Oipnet commented Apr 17, 2020

Curently :
When a user is not authenticated and is required in the policy an http response with 403 is return

Now :
When a user is not authenticated and is required in the policy an http response with 401 is return

@kadevland
Copy link
Copy Markdown

it's good feature and more logical

@taylorotwell
Copy link
Copy Markdown
Member

Breaking change. May break people's tests, etc.

@kadevland
Copy link
Copy Markdown

kadevland commented Apr 17, 2020

I understand the possibilite of Breaking change.
May be if policy have config file and in config file set active ( by default is not active)
"this authenticated and is required and null response with 401 "
so no break change by default.
@taylorotwell @GrahamCampbell

@Oipnet
Copy link
Copy Markdown
Author

Oipnet commented Apr 22, 2020

@taylorotwell do you think this breaking change can be include in future version like Laravel 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants