[7.x] Updating the make commands to use a custom views path#34050
Closed
arcanedev-maroc wants to merge 1 commit intolaravel:7.xfrom
arcanedev-maroc:fixing-custom-views-folder
Closed
[7.x] Updating the make commands to use a custom views path#34050arcanedev-maroc wants to merge 1 commit intolaravel:7.xfrom arcanedev-maroc:fixing-custom-views-folder
arcanedev-maroc wants to merge 1 commit intolaravel:7.xfrom
arcanedev-maroc:fixing-custom-views-folder
Conversation
This is related to (component, mail, notification) make commands
Member
|
You could put this method in the base GeneratorCommand. |
Contributor
Author
|
Do you mean: moving/refactoring the Something like this: https://github.com/arcanedev-maroc/framework/commit/8df11245a8132c96dc52cc851a974265821d2483 ? |
Contributor
Author
|
ping @taylorotwell |
Contributor
Author
|
@taylorotwell @driesvints @GrahamCampbell can you review and reopen this PR ? |
Member
|
@arcanedev-maroc just send in a new one please |
Contributor
Author
|
@driesvints Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix an issue when using a custom folder structure. In my case, the
viewsfolder is located in the base path.This can be achieved by setting the custom
viewsfolder in config file:When running commands like:
It creates the
resources/views/{new-blade-files}instead ofviews/{new-blade-files}NOTE: Let me know if i've missed a console commad that generates blade files 👍