Merged
Conversation
driesvints
commented
Nov 8, 2021
|
|
||
| Post::join('comments', 'comments.post_id', '=', 'posts.id')->where('posts.id', '>', 1)->orderBy('posts.id')->limit(1)->delete(); | ||
| Post::join('comments', 'comments.post_id', '=', 'posts.id') | ||
| ->where('posts.id', '>', 8) |
Member
Author
There was a problem hiding this comment.
SQLite and MySQL behave different here so we should adjust the test accordingly.
driesvints
commented
Nov 8, 2021
|
|
||
| if ($this->driver !== 'mysql') { | ||
| $this->markTestSkipped('Test requires a MySQL connection.'); | ||
| } |
Member
Author
There was a problem hiding this comment.
Skip tests on non-MySQL connections so they don't error out when using other drivers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
@groupcall as well.EloquentUpdateTest&EloquentDeleteTestto run on all engines and skip a few tests on MSSQL.