[8.x] Add Support for custom Increment / Decrement in Collection range#39672
Closed
ManojKiranA wants to merge 3 commits intolaravel:8.xfrom
Closed
[8.x] Add Support for custom Increment / Decrement in Collection range#39672ManojKiranA wants to merge 3 commits intolaravel:8.xfrom
ManojKiranA wants to merge 3 commits intolaravel:8.xfrom
Conversation
ManojKiranA
changed the title
GrahamCampbell
changed the title
GrahamCampbell
requested changes
Nov 18, 2021
| * | ||
| * @param int $from | ||
| * @param int $to | ||
| * @param int|float $from |
Collaborator
There was a problem hiding this comment.
👎 for allowing floats here. What was the use case?
Member
|
This PR contains breaking changes to the method signature. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default php range function will accept 3rd argument for
increment/decrementbetween elements in the sequence.Since
Collection::rangefunction uses native php function I have added support for 3rd argument.Before:
collect(range(2,10,2));After:
collect()->range(2,10,2);