[9.x] Add soleValue method to Collections#44309
Closed
ash-jc-allen wants to merge 3 commits into
Closed
Conversation
Member
|
@ash-jc-allen can you rebase with 9.x? We fixed the failing build there. |
Contributor
Author
|
@driesvints Sweet! I've done that now 🙂 |
Member
|
Think I'm going to hold off on this one for now. You can macro it in. |
Contributor
Author
|
That's no problem at all, I'll use a macro 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! This PR proposes a small
soleValuemethod that can be added toCollections andLazyCollections.The new method tries to mimic the
soleValuethat's available in the query builder (added in this PR: #41368).The idea behind using this is that it gives you more confidence that:
As a basic example, before this method, I might have written something similar to this:
But with the new method, I could write it like this:
If the item doesn't exist, an
Illuminate\Support\InvalidKeyExceptionexception will be thrown.If you think this might be something worth merging and you need any changes making to it, please let me know and I'll sort it ASAP 😄