[9.x] replace string|null with ?string #45671
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we want to go this way, but I'll give it a try.
Currently,
string|nulland?stringare used through eachother. For example:framework/src/Illuminate/Auth/Access/HandlesAuthorization.php
Line 22 in 37bbb8c
framework/src/Illuminate/Auth/Access/HandlesAuthorization.php
Line 35 in 37bbb8c
I'd prefer
?stringfor variables with a single type, since it improves readability.This PR replaces
string|nullwith?stringand corrects those internal inconsistencies.If this PR gets merged, I'll work on the other types.