Skip to content

[9.x] Fix docblock#45749

Merged
taylorotwell merged 1 commit intolaravel:9.xfrom
michaelnabil230:fix-docblock
Jan 22, 2023
Merged

[9.x] Fix docblock#45749
taylorotwell merged 1 commit intolaravel:9.xfrom
michaelnabil230:fix-docblock

Conversation

@michaelnabil230
Copy link
Copy Markdown
Contributor

No description provided.

@taylorotwell taylorotwell merged commit 8072cb7 into laravel:9.x Jan 22, 2023
@michaelnabil230 michaelnabil230 deleted the fix-docblock branch January 22, 2023 17:40
@GrahamCampbell GrahamCampbell changed the title Fix docblock [9.x] Fix docblock Jan 22, 2023
driesvints pushed a commit that referenced this pull request Feb 3, 2023
`append` and `prepend` methods accept a variadic list of `string`s 

the docblock should be `@param string ...$values` in order to be correct

otherwise IDE would mark an error
taylorotwell pushed a commit that referenced this pull request Feb 8, 2023
Bladecompiler check accepts mixed parameters for user func
Schemastate makeProcess accepts mixed parameters for user func

Viewcontroller invoke accepts mixed args(eg status is int and data an array)

(Factory)Sequence accepts mixed values

QueueingFactory que accepts mixed params

the docblock should be `@param type ...$values` instead of the result of $values(array) in order to be correct

otherwise IDE would mark an error

Signed-off-by: René Geuze <renegeuze@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants