[11.x] Add symfony/polyfill-php83 to component using #[\Override]
#49140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
driesvints
reviewed
Nov 27, 2023
| "laravel/prompts": "^0.1.12", | ||
| "nunomaduro/termwind": "^2.0", | ||
| "symfony/console": "^7.0", | ||
| "symfony/polyfill-php83": "^1.28", |
Member
There was a problem hiding this comment.
Don't we only need it here? main composer.json and the one from http already require symfony/http-foundation
Member
Author
There was a problem hiding this comment.
That's another option, the only risk if symfony/http-foundation suddenly remove the deps, we should be able to detect but any installation using outdated laravel versions with latest symfony deps could cause symfony/polyfill-php83 to be missing.
Member
There was a problem hiding this comment.
Right. Will leave it up to you. Just feels like a strange dependency to keep around.
GrahamCampbell
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested via #49130 (comment)