Conversation
this new feature helps reduce a lot of boilerplate code.
|
My only concern here is that comments for properties that contains some more info are not there anymore. |
|
Sorry, but this is really not good pattern.
Together it brings worse readability because both types of declaration have different "rhythm". |
|
Can't we keep the properties comments in the constructor docblock? |
There was a problem hiding this comment.
Type hinting the callables as \Closure might be a breaking change for some people. Before this change callable instances were also accepted
@donnysim you are right, I only looked at the properties but did not check the constructor.
|
@JurianArie i don't see any type hints being changed here tho 🤔 they all were and still are Closure type. |
|
I do think I'll just leave this off for now since we lose information from docblocks. |
this new feature helps reduce a lot of boilerplate code.
resubmission of #53807
I had originally started the original PR against master, but then was concerned if there were changes prior to the v12 release, we might run into some annoying merge conflicts. as long as we're not concerned about that too much, then this master targeted PR should be good.