feat: Allow custom precision in Number::currency()#54848
Closed
philharmonie wants to merge 1 commit into
Closed
Conversation
This update enhances the `Number::currency()` method by introducing an optional `$precision` parameter. Users can now specify the number of decimal places when formatting currency values. Previously, the method always used the default precision for each currency. With this change, developers can override this behavior by passing a specific precision value. Example usage: ```php Number::currency(1234.56, 'EUR', null, 0); // Outputs: "1.235 €" Number::currency(1234.56, 'EUR', null, 2); // Outputs: "1.234,56 €" ```
Contributor
|
This really is a popular topic 😂 But hasn't this already been done in #54456? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update enhances the
Number::currency()method by introducing an optional$precisionparameter, allowing developers to specify the number of decimal places when formatting currency values.Before vs. After:
Previously, the method always used the default precision for each currency, which was sometimes unnecessary or inconsistent with application requirements:
After this update:
Developers can now explicitly set the precision when needed:
Benefits to End Users
Why It Doesn't Break Existing Features
NumberFormatter: The change does not override any locale-specific behavior unless explicitly requested by the developer.How It Makes Web Development Easier
currency(), reducing boilerplate code.