Added property with file path to MigrationStarted and MigrationEnded migration events#55110
Closed
andrey-helldar wants to merge 1 commit intolaravel:12.xfrom
Closed
Added property with file path to MigrationStarted and MigrationEnded migration events#55110andrey-helldar wants to merge 1 commit intolaravel:12.xfrom
MigrationStarted and MigrationEnded migration events#55110andrey-helldar wants to merge 1 commit intolaravel:12.xfrom
Conversation
…ed` migration events
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The situation is very simple:
MigrationStartedandMigrationEndedevents, which indicate the start and end of a particular migration, contain the migration instance itself and the start method -upordown;Considering that the reference to the executable class is located next to the object at the moment of calling the event, it would be more logical to pass the path to the file as a parameter.
This will improve the mechanism for interacting with migrations, allowing you to perform some action when a particular migration is triggered.