[JSON:API] add tests for type, included merge and id in attributes #57589
+79
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
reviewed
Oct 31, 2025
crynobone
reviewed
Oct 31, 2025
crynobone
reviewed
Oct 31, 2025
|
|
||
| public function testResourceTypeIsPickedFromMorph() | ||
| { | ||
| Relation::morphMap([JsonApiModel::class => 'json-api-model']); |
There was a problem hiding this comment.
Should it be ['json-api-model' => JsonApiModel::class]?
There was a problem hiding this comment.
Oh, yeah, that's what I get for doing it during work break. Will get back to this in a bit 👍
crynobone
changed the title
…-resource Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
reviewed
Nov 3, 2025
| 'email' => 'deputy@example.com', | ||
| ], | ||
| ], $responseData['included'][0]); | ||
| } |
There was a problem hiding this comment.
@timacdonald need your input on this and how it should be affected, especially when the resource (e.g., UserResource) needs id, name, and email values to be available, but the relationship only loads partial values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added failing test to assert that:
I'm unsure how the intended way will be to test the data so picked what I found around other tests.