[12.x] ChainedBatch keeps queue and connection of wrapped batch #57630
+23
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ChainedBatch do not use queue and connection of wrapped PendingBatch. When it creates new batch in src/Illuminate/Bus/ChainedBatch.php:86, connection and queue of original batch is lost.
Currenctly, if we have code
Job 3 will be dispatched to queue
other, but Jobs 1 and 2 will be dispatched to queuedefault, even it is explicitly defined to use other queue.In this PR chainedBatch takes queue and connection from wrapped batch, so later, when converted back to pending batch, it has same queue and connection as before.
Example of tests failing before fix https://github.com/laravel/framework/actions/runs/19057979725