Fix FormRequest passedValidation data sync issue #57666
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When
replace()ormerge()methods are called inpassedValidation(), the changes were not reflected in thevalidated()method because the validator instance held a copy of the original data.Root Cause:
The validation flow in
ValidatesWhenResolvedTrait::validateResolved()creates the validator instance before callingpassedValidation(). WhenpassedValidation()modifies the request data usingreplace()ormerge(), the validator still has the old data, sovalidated()returns the original data instead of the modified data.Solution:
After
passedValidation()is called, sync the validator's data with the current request data usingsetData(). This ensures that any modifications made to the request data inpassedValidation()are properly reflected invalidated().Changes:
ValidatesWhenResolvedTrait::validateResolved()to sync validator data afterpassedValidation()passedValidation()Testing:
testPassedValidationDataIsReflectedInValidatedMethod()test casevalidationData()method to get current data andsetData()to update the validatorFixes: #57659