Skip to content

Conversation

@lucasmichot
Copy link
Contributor

@lucasmichot lucasmichot commented Nov 25, 2025

This PR refactors several parts of the codebase to use more explicit and modern PHP typecasting (e.g., (int), (float), ect...) for better readability and intent.

Why:

  • Enhances clarity of type conversions.
  • No functional changes — purely a cleanup.

Impact:

  • Fully backward-compatible.
  • No behavioral changes.
  • Requires review of casting correctness only.

cf. https://mlocati.github.io/php-cs-fixer-configurator/#version:3.88|fixer:modernize_types_casting


pint was not run against those changes, as it would break StyleCI

@cosmastech
Copy link
Contributor

pint doesn't run against the codebase, StyleCI does.

So you'd have to run just this change against the codebase with pint and then commit that. I doubt StyleCI would overwrite it, but I am not totally sure.

@taylorotwell taylorotwell merged commit bf3d9bb into laravel:12.x Nov 25, 2025
76 checks passed
@lucasmichot
Copy link
Contributor Author

So you'd have to run just this change against the codebase with pint and then commit that. I doubt StyleCI would overwrite it, but I am not totally sure.

It would.

@lucasmichot lucasmichot deleted the 12x/modernize-types-casting branch November 25, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants