[12.x] Introduce FluentPromise to allow for cleaner chaining in Pool - #57967
Merged
Conversation
cosmastech
marked this pull request as draft
November 28, 2025 16:45
cosmastech
marked this pull request as ready for review
November 28, 2025 16:48
FluentPromise to allow for cleaner chaining in Pool callbacks
FluentPromise to allow for cleaner chaining in Pool callbacksFluentPromise to allow for cleaner chaining in Pool
akyrey
pushed a commit
to akyrey/framework
that referenced
this pull request
Dec 29, 2025
laravel#57967) * laravel fluent promise * docblocks * protected * Update PendingRequest.php * formatting --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guzzle Promises are immutable, which means userland chaining in Pool is not possible since we don't have access to the underlying array.
For example, this will not work to return the string length of each request. It will instead just return the responses.
Were this PR to be accepted, then the above will produce: