[12.x] Fix cache:clear command exit code on failure #57988
Merged
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
cache:clearcommand was returningvoid(which Symfony Console interprets as exit code0) even when the cache flush operation failed. While the error message is printed to stdout, the exit code doesn't reflect the failure, which breaks the standard Unix convention that automation tools rely on.Problem
The
$this->components->error()method returnsvoid, so the command exits with code0despite the failure. Tools can still detect failure by parsing stdout, but this is fragile compared to checking exit codes.Solution
This follows the pattern used consistently in other Laravel commands like
db:wipe,migrate,db:seed, etc.Changes
self::FAILURE(exit code 1) when cache flush failsself::SUCCESS(exit code 0) on successful cache clearvoidtoint