[12.x] Allow easier opting out of DatabaseLock prune lottery
#58152
+25
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cosmastech Thank you for adding this! Is there any chance you'd be willing to add this to the docs as well? |
iam-subho
pushed a commit
to iam-subho/laravel-core
that referenced
this pull request
Dec 18, 2025
…el#58152) * easy no lottery * move pruning to separate method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As my colleague pointed out here, the database lock prune lottery can be an expensive footgun. The fact that it is non-deterministic means that extra queries are executed which, without Chris' index, may cause a request or queued job to choke.
In this PR, I have added an easy way to opt out of the lottery execution by allowing null to be passed. This shouldn't break any existing implementation, as it requires specifying the lottery parameter as null. Prior to this, in order to opt out of the lottery, you had to pass something like
[-1, 1]. This isn't obvious or clear.In our codebase, I'm writing a console command that prunes DB locks, which we will schedule to run every minute. If that's helpful, I can add the console command here as well.