[12.x] chore: add deprecation to Request::get() #58635
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent method is deprecated, but it doesn't show up in the IDE because the child method is not marked as deprecated.
calebdw
force-pushed
the
calebdw/push-qknkvlvtzuxo
branch
from
648c684 to
bdba05f
Compare
Contributor
Author
|
@taylorotwell, can we please get a patch release so I don't have to wait a week for the warnings to go away? 🙏 |
|
Hi @taylorotwell, |
Contributor
Author
|
@m0nclous, I can't speak for Taylor, but here's some things I've noticed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent method is deprecated, but it doesn't show up in the IDE because the child method is not marked as deprecated.
Thanks!