[12.x] Support afterSending method on notification
#58654
Merged
+44
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a notification is sent, I sometimes want to do something small, for example, update a single property on the eloquent model used by the notification. Currently, you have to create a dedicated listener that listens for the NotificationSent event.
That is a lot of code to do something very simple.
This PR improves that by allowing you to implement an
afterSendingmethod in your notification class. Now you don't need a dedicated listener class anymore. When you look at the notification class, you also now immediately see what happens to the model after sending the notification instead of having to look for a separate class that contains some logic linked to that specific notification.