[12.x] Fix: @return for resolveResourceRelationshipIdentifiers()#58764
Merged
taylorotwell merged 3 commits intolaravel:12.xfrom Feb 12, 2026
Merged
[12.x] Fix: @return for resolveResourceRelationshipIdentifiers()#58764taylorotwell merged 3 commits intolaravel:12.xfrom
@return for resolveResourceRelationshipIdentifiers()#58764taylorotwell merged 3 commits intolaravel:12.xfrom
Conversation
shaedrich
reviewed
Feb 11, 2026
| * Resolves `relationships` for the resource's data object. | ||
| * | ||
| * @return string|int | ||
| * @return array |
Contributor
There was a problem hiding this comment.
You could narrow this further down:
Suggested change
| * @return array | |
| * @return array{}|array{data: array{id: string, type: string}[]|null} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
resolveResourceRelationshipIdentifiers()method returns anarray, but the docblock incorrectly specifies the return type asstring|int. This PR fixes the docblock to correctly reflect thearrayreturn type.