[12.x] cast Batch::progress() return value to int#58767
Merged
taylorotwell merged 2 commits intolaravel:12.xfrom Feb 12, 2026
Merged
[12.x] cast Batch::progress() return value to int#58767taylorotwell merged 2 commits intolaravel:12.xfrom
Batch::progress() return value to int#58767taylorotwell merged 2 commits intolaravel:12.xfrom
Conversation
shaedrich
reviewed
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented return type for the
Batch::progress()method is integer but theroundfunction returns float even though it doesn't contain any decimals.This will cause a
TypeErrorwhen the value is float and is consumed by a function expecting an integer in strict modedeclare(strict_type=1);To resolve this issue, the rounded value should be cast to an integer.
Edit:
int<0, 100>- suggested by @shaedrich