[13.x] Ensure insertOrIgnoreReturning only marks records as modified when rows are inserted#59083
Merged
taylorotwell merged 2 commits intolaravel:13.xfrom Mar 5, 2026
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If all the rows conflict, nothing is inserted.
I noticed
$this->connection->recordsHaveBeenModified();was being called regardless - which means if you use a sticky connection subsequent reads hit the write server unnecessarily.This aligns the behavior with
insertOrIgnore, which only marks the connection as modified when rows are actually affected.13.x cause thats where insertOrIgnoreReturning is.. :)