[12.x] Lazily evaluate value for constraints in HasOneOrManyThrough#59231
Merged
taylorotwell merged 2 commits intolaravel:12.xfrom Mar 16, 2026
Merged
[12.x] Lazily evaluate value for constraints in HasOneOrManyThrough#59231taylorotwell merged 2 commits intolaravel:12.xfrom
HasOneOrManyThrough#59231taylorotwell merged 2 commits intolaravel:12.xfrom
Conversation
Contributor
Author
|
The failing tests seem to be unrelated to this PR, as they're also failing in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a scenario, where:
integerwith a value>= 1calledPositiveIntegerHasOneOrManyThroughresults in an exceptionThe reason is, that at the moment of calling
addConstraintsin the context of constructor of eitherHasOneThroughorHasManyThrough, the$farParentis empty.This means our cast, which is highly strict, results in an exception.
When debugging I've noticed that, unlike any other relation's
addContraintsmethod, this is for some (unknown) reason evaluated even if thestatic::$constraintsis set tofalsewhich, coincidentally, breaks our application.This PR changes the behaviour in
\Illuminate\Database\Eloquent\Relations\HasOneOrManyThrough::addConstraintsto resolve the value for constraint in theifstatement, therefore fixing this inconsistency (and our bug).