[13.x] Cache database queue lock type to avoid repeated PDO version detection#59348
Draft
JoshSalway wants to merge 3 commits intolaravel:13.xfrom
Draft
[13.x] Cache database queue lock type to avoid repeated PDO version detection#59348JoshSalway wants to merge 3 commits intolaravel:13.xfrom
JoshSalway wants to merge 3 commits intolaravel:13.xfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Ensures that getPdo() and getAttribute() are only called once across multiple getLockForPopping() invocations, validating the lock type caching behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59350
Summary
getLockForPopping()makes 2 PDO attribute calls, creates Stringable objects, parses version strings, and runsversion_compare()on every single job pop. The DB engine and version never change during a worker's lifetime, so this work is redundant after the first call.Problem
Every call to
DatabaseQueue::pop()triggersgetLockForPopping(), which:PDO::getAttribute(ATTR_DRIVER_NAME)PDO::getAttribute(ATTR_SERVER_VERSION)Stringableinstanceversion_compare()For high-throughput queue workers processing thousands of jobs, this adds up to significant unnecessary overhead.
Solution
Cache the computed lock type in an instance property after the first call. Subsequent calls return the cached value directly, eliminating repeated PDO calls and string parsing for the lifetime of the worker process.
Before
Every
pop()call triggers full PDO version detection and string comparison, regardless of how many times it has already been computed.After
PDO version detection runs once on the first
pop(), then the cached lock type is returned for all subsequent calls.Test plan