[13.x] Support #[Delay] attribute on queued mailables#59577
Closed
sumaiazaman wants to merge 2 commits intolaravel:13.xfrom
Closed
[13.x] Support #[Delay] attribute on queued mailables#59577sumaiazaman wants to merge 2 commits intolaravel:13.xfrom
sumaiazaman wants to merge 2 commits intolaravel:13.xfrom
Conversation
The #[Delay] attribute is supported for queued jobs, event listeners, and notifications via getAttributeValue(), but queued mailables only check the $delay property and ignore the attribute entirely. This adds the ReadsQueueAttributes trait to Mailable and uses getAttributeValue() in the queue() method, consistent with how Bus\Dispatcher, Events\Dispatcher, and NotificationSender handle the #[Delay] attribute.
Member
|
Use the support trait. |
Contributor
Author
Updated to use ReadsClassAttributes support trait instead of ReadsQueueAttributes. Thanks for the feedback! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
#[Delay]attribute is supported for queued jobs (Bus\Dispatcher), event listeners (Events\Dispatcher), and notifications (NotificationSender) viagetAttributeValue(), but queued mailables only check the$delayproperty and ignore the attribute entirely.This means the following does not work as expected:
Changes
ReadsQueueAttributestrait toMailableMailable::queue()to usegetAttributeValue()for reading delay, consistent with howBus\Dispatcher::pushCommandToQueue(),Events\Dispatcher::queueHandler(), andNotificationSender::queueNotification()handle the#[Delay]attribute$delayproperty still takes precedence when explicitly set (not default), matching the behavior ofgetAttributeValue()Test Plan
#[Delay]attribute is respected on queued mailables