[13.x] Return null from Cursor::fromEncoded for malformed payloads#59699
Merged
taylorotwell merged 1 commit intolaravel:13.xfrom Apr 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cursor::fromEncoded()currently returnsnullon non-string input and on payloads that fail JSON decoding, but it does not guard against two other forms of malformed input:null)._pointsToNextItemskey.In both cases the method proceeds to
$parameters['_pointsToNextItems'], which triggers a PHP warning (Undefined array key/Cannot access offset of type string on null) and then returns a nonsensicalCursorinstance, violating the documented@return static|nullcontract.This can be reached by any user-supplied
cursorquery string parameter, so a crafted value will surface warnings in production logs and — in applications that convert warnings to exceptions — raise unexpected errors during request handling.Reproduction
Both of the above currently emit PHP warnings and return a broken
Cursor, rather thannull.Fix
Add a single guard that returns
nullwhen the decoded payload is not an array, or when the_pointsToNextItemskey is absent.Tests
Added four new test cases to
tests/Pagination/CursorTest.phpcovering:null)_pointsToNextItemsAll existing pagination tests continue to pass.